Skip to content

Conversation

@DilmiWickramanayake
Copy link
Contributor

What does this Pull Request accomplish?

Continuously acquires waveforms from NI-SCOPE, and displays data that is converted to binary

Why should this Pull Request be merged?

AB#3176534

What testing has been done?

Manual testing with simulated hardware Dev1
Binary Acquisition Example

Dilmi Wickramanayake added 30 commits June 19, 2025 06:53
Signed-off-by: Dilmi Wickramanayake <[email protected]>
Signed-off-by: Dilmi Wickramanayake <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Test Results

   10 files  ± 0     10 suites  ±0   22s ⏱️ -9s
  227 tests + 3    227 ✅ + 3  0 💤 ±0  0 ❌ ±0 
2 220 runs  +30  2 220 ✅ +30  0 💤 ±0  0 ❌ ±0 

Results for commit ce35c34. ± Comparison against base commit 5ade5a6.

This pull request removes 26 and adds 29 tests. Note that renamed tests count towards both.
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object11-Collection.bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object12-Collection.bytes]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object13-Collection.float]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object14-Collection.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object15-Collection.str]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object16-Collection.bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object17-Collection.bytes]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object18-Collection.float]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object19-Collection.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object20-Collection.str]
…
tests.unit.test_convert ‑ test___durationpb2_timestamp___from_any___valid_python_value
tests.unit.test_convert ‑ test___python_datetime_timedelta___to_any___valid_durationpb2_value
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object11-timedelta]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object12-Collection.bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object13-Collection.bytes]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object14-Collection.float]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object15-Collection.int]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object16-Collection.str]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object17-Collection.bool]
tests.unit.test_convert ‑ test___various_python_objects___get_best_matching_type___returns_correct_type_string[python_object18-Collection.bytes]
…

♻️ This comment has been updated with latest results.

@DilmiWickramanayake DilmiWickramanayake changed the title Add niSCOPE EX Binary Acquisition Example Add NI-SCOPE EX Binary Acquisition Example Aug 4, 2025
@hellovolcano hellovolcano self-requested a review August 6, 2025 16:04
@DilmiWickramanayake DilmiWickramanayake merged commit 57ecee5 into main Aug 6, 2025
14 checks passed
@jfriedri-ni jfriedri-ni deleted the users/DilmiWickramanayake/niscope_binary branch September 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants